Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy::unnecessary_map_or lint #228

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix clippy::unnecessary_map_or lint #228

merged 1 commit into from
Dec 16, 2024

Conversation

waywardmonkeys
Copy link
Contributor

Use is_some_and instead.

@waywardmonkeys
Fix clippy::unnecessary_map_or lint
477892d 
Use `is_some_and` instead.
@nicoburns
Copy link
Contributor

Yes please! I find the semantics of map_or very confusing (had to look them up again to review this PR!)

@waywardmonkeys
Copy link
Contributor Author

This lint triggered in a more recent nightly and yeah, I'm happy to see fewer map_or calls.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Dec 16, 2024
Merged via the queue into linebender:main with commit eb6d5e5 Dec 16, 2024
20 checks passed
@waywardmonkeys waywardmonkeys deleted the clippy-fix-unnecessary_map_or-lint branch December 16, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoburns nicoburns nicoburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @nicoburns